Merged
Conversation
Member
|
LGTM. I don't know what's up with CI. |
mansona
force-pushed
the
fix-remote-blueprints
branch
from
6b3b041 to
a10f471
Compare
This was referenced Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the use of ember-cli-update with the v2 addon blueprint https://github.com/embroider-build/addon-blueprint
I know there are a few tests to fix but it shows the main things that needed to change:
lastNode8Version-sbwhich I'm assuming was--skip-bowerI'm going to get tests passing on this but I'm wondering if now is a good time to remove the
lastNode8Versionsince it has the comment// remove when node 8 is droppedwhich has already happened 🤔