This repository was archived by the owner on Mar 4, 2020. It is now read-only.
revert: "FIXME: Comment out TRACE_EVENT_METADATA1 call"#60
Merged
codebytere merged 1 commit intoelectron-node-v10.2.0-3.0.xfrom Sep 19, 2018
Merged
revert: "FIXME: Comment out TRACE_EVENT_METADATA1 call"#60codebytere merged 1 commit intoelectron-node-v10.2.0-3.0.xfrom
codebytere merged 1 commit intoelectron-node-v10.2.0-3.0.xfrom
Conversation
This reverts commit 19d1193.
ckerr
approved these changes
Sep 8, 2018
alexeykuzmin
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 19d1193.
It is safe to merge it now, but the Node reference should be updated only after electron/electron#14503 is backported to
3-0-x.