Improve support for native compilation in the wasm build#2
Open
tachyonicbytes wants to merge 1 commit intoelectric-sql:wasmfrom
Open
Improve support for native compilation in the wasm build#2tachyonicbytes wants to merge 1 commit intoelectric-sql:wasmfrom
tachyonicbytes wants to merge 1 commit intoelectric-sql:wasmfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been playing around with pglite, trying to see if it still compiles natively, because that would be interesting to use as well. It doesn't compile right now. I am not sure keeping native compilation is in scope of the
postgres-wasmproject, but this PR improves it.As it is now,
src/backend/Makefilestill has to be modified. Ideally, aPORTNAME=emscriptenshould be added.