Enable dynamically loaded postgres extensions#13
Open
var77 wants to merge 3 commits intoelectric-sql:wasmfrom
Open
Enable dynamically loaded postgres extensions#13var77 wants to merge 3 commits intoelectric-sql:wasmfrom
var77 wants to merge 3 commits intoelectric-sql:wasmfrom
Conversation
…ssues and remove EMULATE_FUNCTION_POINTER_CASTS flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAIN_MODULE=1, but it will export all postgres symbols to JS, in emscripten there's a bug related to symbol collision issue with WASI symbols. Postgres has symbolproc_exitand symbol with the same name also exists in WASI runtime, so after exporting this symbol we are getting runtime error thatproc_exitfromwasi_snapshot_preview_1is not found. I have renamed postgres symbol topg_proc_exitto fix the issue until the fix from emscripten will be available. This may only break extensions which are using theproc_exitfunction from postgres.EMULATE_FUNCTION_POINTER_CASTSflag, sodlsymcould work.dfmgr.cto allow passing any URL for extension wasm file as now the extension control file can contain full URL to wasm file undermodule_pathname