refactor(datasets-raw): consolidate raw dataset type across extractors#1883
Merged
refactor(datasets-raw): consolidate raw dataset type across extractors#1883
Conversation
LNSD
changed the title
LNSD
changed the title
LNSD
force-pushed
the
lnsd/feat-datasets-raw-dataset-type
branch
from
06619af to
78a67bb
Compare
shiyasmohd
approved these changes
Mar 2, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
Overall LGTM.
Only issue is handling GetRawDatasetError::NotARawDataset being handled as retryable.
Replace per-extractor `Dataset` structs with the canonical `datasets_raw::dataset::Dataset`, eliminating duplicate implementations and centralizing raw dataset identity. - Delete `dataset.rs` from evm-rpc, firehose, and solana extractors; their `dataset()` fns now return `RawDataset` - Inline dataset resolution into raw `dump`, matching derived `dump` pattern: both now take `&HashReference` and resolve internally via `DatasetStore::get_dataset` - Simplify `resolve_raw_dataset_from_dependencies` to downcast `Arc<RawDataset>` directly without async store call - Assert in `RawDataset::new` that all table networks match the dataset network Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/feat-datasets-raw-dataset-type
branch
from
78a67bb to
a86ac08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace per-extractor
Datasetstructs with the canonicaldatasets_raw::dataset::Dataset, eliminating duplicate implementations and centralizing raw dataset identity.dataset.rsfrom evm-rpc, firehose, and solana extractors; theirdataset()fns now returnRawDatasetDatasetStore::get_raw_dataset()with downcast toArc<RawDataset>andGetRawDatasetErrorresolve_raw_dataset_from_dependenciesto returnArc<RawDataset>directlyArc<RawDataset>intoamp_worker_datasets_raw::dumpinstead of resolving insideRawDataset::newthat all table networks match the dataset network