Added read only permissions to duo-client#308
Open
sfazilud wants to merge 1 commit intoduosecurity:masterfrom
Open
Added read only permissions to duo-client#308sfazilud wants to merge 1 commit intoduosecurity:masterfrom
sfazilud wants to merge 1 commit intoduosecurity:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added new Admin API permission parameters to the
create_integrationandupdate_integrationmethods in the Python client:adminapi_admins_read— read-only admins permissionadminapi_integrations_read— read-only integrations permissionadminapi_settings_read— read-only settings permissionadminapi_allow_to_set_permissions— permission to set permissions (create only)These were added to:
"1"/"0")Motivation and Context
The upstream third-party repo (
trustedpath/third-party/duo_client_python) introduced additional granular read-only permission flags for Admin API integrations. This change brings the open-sourceduo_client_pythonclient in sync with those additions, allowing consumers to configure fine-grained read permissions when creating or updating integrations.How Has This Been Tested?
Added 4 new unit tests in
tests/admin/test_integration.py:test_create_integration_with_permissions— verifies all permission params serialize as"1"whenTruetest_create_integration_with_permissions_disabled— verifies new permission params serialize as"0"whenFalsetest_update_integration_with_permissions— verifies all permission params on update serialize as"1"test_update_integration_with_permissions_disabled— verifies new permission params on update serialize as"0"Types of Changes