Skip to content

Conversation

@mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Dec 19, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212374007733022?focus=true

Description

Removes the SERP easter egg logo toggle. The feature has been out for a few months with no issues.

Steps to test this PR

Happy path

  • Search for a term that has an Easter Egg logo (e.g., "predator", "terminator", "android" etc.)
  • Verify the special logo appears in the omnibar
  • Tap on the logo to see the enlarged version
  • Tap anywhere on the screen to dismiss the enlarged view
  • Enter a search term without special logo e.g. "monkeys"
  • Verify the logo is replaced with the standard DuckDuckGo logo
  • Search for a term that has an Easter Egg logo (e.g., "predator", "terminator", "android" etc.)
  • Navigate away from the SERP page (by clicking a result) and verify the logo is replaced with the standard DuckDuckGo logo

UI changes

N/A


Note

Removes the SERP Easter Egg logo feature flag, simplifying SERP logo handling and updating UI/tests accordingly.

  • Browser/State:
    • Remove SerpEasterEggLogosToggles usage and toggle gating from BrowserTabViewModel; evaluateSerpLogoState now always extracts SERP logo for DuckDuckGo query URLs and clears it otherwise.
  • Omnibar UI:
    • Remove toggle checks in OmnibarLayout and OmnibarLayoutViewModel; always render standard DDG logo for Dax state and handle SerpLogo (including Easter Egg) directly in leading icon state.
  • API:
    • Simplify SerpEasterEggLogosToggles by removing feature() method, leaving only self().
  • Tests:
    • Update and simplify tests to reflect removal of the toggle, deleting disabled-path cases and adjusting expectations to always evaluate/extract or clear SERP logos based on URL.

Written by Cursor Bugbot for commit 702526d. This will update automatically on new commits. Configure here.

@mikescamell mikescamell marked this pull request as ready for review December 19, 2025 17:37
@mikescamell mikescamell force-pushed the feature/mike/remove-serp-easter-egg-logo-feature-toggle branch from 56af370 to 5e11072 Compare December 22, 2025 15:27
Leaving the Toggle class as I'll use it for future update to include setting SERP icons as default icons
@mikescamell mikescamell force-pushed the feature/mike/remove-serp-easter-egg-logo-feature-toggle branch from 5e11072 to 3bee519 Compare December 22, 2025 15:53
@landomen landomen self-assigned this Dec 22, 2025
@mikescamell mikescamell changed the title Remove SERP Easter Egg Toggle Remove SERP Easter Egg Logo Toggle Dec 22, 2025
Copy link
Contributor

@landomen landomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 👍

@mikescamell mikescamell merged commit f3421b9 into develop Dec 22, 2025
25 checks passed
@mikescamell mikescamell deleted the feature/mike/remove-serp-easter-egg-logo-feature-toggle branch December 22, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants