remove length from BINARY data type + support VARBINARY data type#438
Open
leo-schick wants to merge 1 commit intodropbox:masterfrom
Open
remove length from BINARY data type + support VARBINARY data type#438leo-schick wants to merge 1 commit intodropbox:masterfrom
leo-schick wants to merge 1 commit intodropbox:masterfrom
Conversation
skip the length parameter which is used in GenericTypeCompiler
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BINARY data type is already supported via
GenericTypeCompilerbut it has an optional length parameter which is not supported in Hive (see Hive docs).With this PR the length parameter for the BINARY type is removed and the VARBINARY type is mapped to
BINARY.