Add minimal support for querying multiple catalogs#246
Add minimal support for querying multiple catalogs#246AlexandreOuellet wants to merge 10 commits intodropbox:masterfrom
Conversation
|
We're interested in this feature being integrated into a future release of PyHive. Is there any reason (besides failed travis CI) that the PR was never approved? |
|
To be honest, I made this for work, created the PR and forgot about it. I can have a quick look to make it pass the flake8 issues |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=========================================
Coverage ? 92.46%
=========================================
Files ? 14
Lines ? 1553
Branches ? 170
=========================================
Hits ? 1436
Misses ? 84
Partials ? 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is as far as I can get tonight. It's alright with python 3.6, but fails with 3.5, 3.4 and 2.7. Feel free to fork off of my branch if you want to contribute to it. |
|
Thanks, I found a similar str bug and made a PR against your branch that fixes the build for python 3.4/5, and added fix for python 2.7 syntax. |
Fix python 2.7 and 3.4/5 syntax
bkyryliuk
left a comment
There was a problem hiding this comment.
It would be great to see the examples on how would it behave & add some unit tests
|
Hi Could you give an example on how to create the engine and query multiple catalgoues ? |
|
I noticed that this repo currently says it's unsupported, but is there any way we would be able to get this PR merged and into another release? I also now have the need for the functionality here. Happy to help implement whatever tests are required to get this through. |
|
Aleandre Ouellet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This adds the catalog names in front of fields and table when needed. It will most likely require more finetuning but is a working prototype