Register new tasks after plugin is configured.#294
Merged
joshafeinberg merged 1 commit intodropbox:mainfrom Aug 18, 2025
Merged
Register new tasks after plugin is configured.#294joshafeinberg merged 1 commit intodropbox:mainfrom
joshafeinberg merged 1 commit intodropbox:mainfrom
Conversation
Avoids NPE when trying to check whether a project is affected while creating tasks. fixes dropbox#287
|
|
jxblum
added a commit
to jxblum/AffectedModuleDetector
that referenced
this pull request
Jul 26, 2025
…ll Gradle projects have been properly evaluated Fixes dropbox#287 See dropbox#294
joshafeinberg
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids NPE when trying to check whether a project is affected while creating tasks.
fixes #287
Context
After #270, the plugin registers new tasks during initial setup, then configures the plugin and initializes the
AffectedModuleDetectorafter projects are evaluated. This fixed #205, but registering the test plugins requires theAffectedModuleDetector, which isnulluntilAffectedModuleDetector.configure(project)is called.registerCustomTasks()already wrapped its setup inrootProject.afterEvaluate, butregisterTestTasks()did not. The execution order is important here, so theregisterfunctions were moved afterAffectedModuleDetector.configure(), after projects are evaluated.