Add Persistent#max_requests to prevent ECONNRESET #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Many servers have a max_requests tunable on keepalive connections that is tuned to less than infinite. Some of these servers incorrectly close the connection out-of-band (rather than replying with Connection:close). In these cases, it is advantageous to avoid the resulting ECONNRESET, and preemptively reset those connections. * Additional potential work that could be done later: Make a closing request on the last request. Add a detect_max_requests helper at the top level. * Exmaple configuration link: http://wiki.nginx.org/HttpCoreModule#keepalive_requests
Contributor
Author
|
Travis failure for 1.9.2 is a false negative - the build is missing OpenSSL. |
There was a problem hiding this comment.
It should be requests >= @max_requests, I believe
drbrain
added a commit
that referenced
this pull request
Jul 23, 2013
Add Persistent#max_requests to prevent ECONNRESET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tuned to less than infinite. Some of these servers incorrectly close the
connection out-of-band (rather than replying with Connection:close). In these
cases, it is advantageous to avoid the resulting ECONNRESET, and preemptively
reset those connections.
the last request. Add a detect_max_requests helper at the top level.
http://wiki.nginx.org/HttpCoreModule#keepalive_requests