Merged
Conversation
Death111
requested changes
Apr 3, 2019
src/main/java/de/doubleslash/keeptime/view/ReportController.java
Outdated
Show resolved
Hide resolved
src/main/java/de/doubleslash/keeptime/view/ReportController.java
Outdated
Show resolved
Hide resolved
src/main/java/de/doubleslash/keeptime/common/ColorTimeLine.java
Outdated
Show resolved
Hide resolved
src/main/java/de/doubleslash/keeptime/common/ColorTimeLine.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
im ready :) |
Death111
requested changes
Apr 9, 2019
src/main/java/de/doubleslash/keeptime/controller/Controller.java
Outdated
Show resolved
Hide resolved
src/main/java/de/doubleslash/keeptime/view/ReportController.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Merging would be nice at this point 😁 |
Death111
reviewed
Apr 11, 2019
| if (optionalProject.isPresent()) { | ||
| return optionalProject.get().isWork(); | ||
| for (final Project p : model.getAllProjects()) { | ||
| if (p.getId() == project.getId() && project.isWork()) { |
Collaborator
There was a problem hiding this comment.
this should be p.isWork, otherwise this does not help
Death111
reviewed
Apr 11, 2019
| <ColumnConstraints hgrow="SOMETIMES" maxWidth="243.0" minWidth="10.0" prefWidth="77.0" /> | ||
| <ColumnConstraints hgrow="SOMETIMES" maxWidth="374.0" minWidth="0.0" prefWidth="216.0" /> | ||
| <ColumnConstraints hgrow="SOMETIMES" maxWidth="400.0" minWidth="0.0" prefWidth="146.0" /> | ||
| <ColumnConstraints hgrow="SOMETIMES" maxWidth="258.0" minWidth="0.0" prefWidth="102.0" /> |
Collaborator
There was a problem hiding this comment.
brauchen wir die changes hier? da wir ja keine neue spalte haben, sollten die alten werte ok sein oder?
Contributor
Author
There was a problem hiding this comment.
nope weil wir ja jetzt eine spalte weniger haben
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a colorized timeline to the report and put logic for in in separate class