[release/7.0-staging] Fix createdump arg parsing for signal-based exceptions#85423
Merged
hoyosjs merged 1 commit intorelease/7.0-stagingfrom Apr 28, 2023
Merged
Conversation
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #85422 to release/7.0-staging /cc @hoyosjs Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
mikem8361
approved these changes
Apr 26, 2023
jeffschwMSFT
approved these changes
Apr 27, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
jeffschwMSFT
added
the
Servicing-consider
rbhanda
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #85422 to release/7.0-staging
Handle NT_SIGINFO parameters on macOS for hardware-signal based exceptions.
/cc @hoyosjs
Customer Impact
This was a regression w.r.t 7.0.4 and 6.0.15. The regression caused no dumps or crash reports to be generated for crashes on hardware exceptions.
Testing
Testing in automation to be added out of band. Reported scenarios validated manually.
Risk
Low risk - linux uses the same parsing logic, and the values don't get used if not needed (macOS doesn't try to use the values).