Skip to content

Fix the outer loop compilation errors#56889

Merged
jakobbotsch merged 1 commit intodotnet:mainfrom
kunalspathak:outer_loop
Aug 5, 2021
Merged

Fix the outer loop compilation errors#56889
jakobbotsch merged 1 commit intodotnet:mainfrom
kunalspathak:outer_loop

Conversation

@kunalspathak
Copy link
Copy Markdown
Contributor

#56757 broke the outerloop Pri1 test build. We are getting following build errors:

/__w/1/s/src/coreclr/tools/Common/TypeSystem/Common/ExplicitLayoutValidator.cs(56,52): error CS0573: 'ExplicitLayoutValidator': cannot have instance property or field initializers in structs [/__w/1/s/src/tests/ilverify/ILVerification.Tests.csproj]
##[error]src/coreclr/tools/Common/TypeSystem/Common/ExplicitLayoutValidator.cs(56,52): error CS0573: 'ExplicitLayoutValidator': cannot have instance property or field initializers in structs

The fix just moves the initialization into the constructor. I hope it preserves what we want to achieve.

@kunalspathak
Copy link
Copy Markdown
Contributor Author

kunalspathak commented Aug 5, 2021

@davidwrighton @trylek

@kunalspathak kunalspathak added the blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs label Aug 5, 2021
@jakobbotsch jakobbotsch merged commit e4d4f98 into dotnet:main Aug 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-crossgen2-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants