[NO-MERGE, NO-REVIEW] Experiment: try remove test exclusions by mrek-msft · Pull Request #125335 · dotnet/runtime

mrek-msft · 2026-03-09T14:15:58Z

Just for running pipelines on this experiment.

dotnet-policy-service · 2026-03-09T14:17:18Z

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This is an explicitly marked experimental/no-merge PR that removes [ActiveIssue] test exclusions for iOS and tvOS platforms on two test files, in order to observe pipeline results when those tests are allowed to run on those platforms. It also contains an intentional throw new Exception("test foo bar") inserted into a test method as part of the experiment.

Changes:

Removal of [ActiveIssue] exclusions for iOS/tvOS from two tests in ArrayTests.cs (issues #60583).
Removal of [ActiveIssue] exclusion for iOS/tvOS from one test in ConfigurationExtensionTest.cs (issue #60584), plus an injected throw new Exception("test foo bar") that unconditionally fails the test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs`	Removes `[ActiveIssue]` attributes from two tests, enabling them to run on iOS/tvOS
`src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs`	Removes `[ActiveIssue]` attribute from one test and adds a `throw new Exception("test foo bar")` that makes the test unconditionally fail

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-09T14:17:56Z

...libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs

-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void AddUserSecrets_FindsAssemblyAttribute()
        {
+            throw new Exception("test foo bar");


A throw new Exception("test foo bar") statement has been intentionally added at the top of the AddUserSecrets_FindsAssemblyAttribute test method. This will cause the test to unconditionally throw an exception and fail immediately, without executing any of the actual test logic. This appears to be debug/experimental code that must not be merged. The PR title says "NO-MERGE, NO-REVIEW" but this change would break the test suite if somehow merged.

Suggested change

throw new Exception("test foo bar");

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (2)

src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs:875

This test writes files directly into _basePath (AppContext.BaseDirectory) and then relies on the default configuration base path to resolve "test.json"/"xmltest.xml". On iOS/tvOS, writing into AppContext.BaseDirectory commonly fails (read-only), which is why this was previously excluded. Consider creating the files under the test file system/temp directory and calling SetBasePath(...) explicitly for determinism, or keep the platform exclusion until the underlying issue is resolved.

        [Fact]
        public void GetDefaultBasePathForSources()
        {
            var builder = new ConfigurationBuilder();

            var jsonConfigFilePath = Path.Combine(_basePath, "test.json");
            var xmlConfigFilePath = Path.Combine(_basePath, "xmltest.xml");
            _fileSystem.WriteFile(jsonConfigFilePath, _jsonConfigFileContent, absolute: true);
            _fileSystem.WriteFile(xmlConfigFilePath, _xmlConfigFileContent, absolute: true);

            builder.AddJsonFile("test.json").AddXmlFile("xmltest.xml");

src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs:58

Removing the iOS/tvOS ActiveIssue re-enables this test on Apple mobile, but it creates a 'refs' directory and writes a file under AppContext.BaseDirectory. On iOS/tvOS the app base directory is typically not writable, so this will throw during Directory.CreateDirectory/File.WriteAllText. Consider writing the temp assembly to a writable temp directory (e.g., Path.GetTempPath()) and cleaning it up, or keep the platform exclusion until the underlying issue is fixed.

        [Fact]
        public void ResolveReferencePathsAcceptsNullCustomResolvers()
        {
            var library = TestLibraryFactory.Create();
            var assemblyPath = Path.Combine(AppContext.BaseDirectory, "refs", library.Name + ".dll");
            Directory.CreateDirectory(Path.GetDirectoryName(assemblyPath));

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-11T13:00:44Z

src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void DifferentConfigSources_Merged_KeysAreSorted()
        {
            var config = BuildConfig();


On Apple mobile the constructor writes the config files under Path.GetTempPath(), but BuildConfig() adds sources using only the file names and does not set the builder base path to that temp directory. When this test is re-enabled on iOS/tvOS, the providers will look under the default base path (typically AppContext.BaseDirectory) and won't find the temp files. Fix by setting the base path/file provider to the directory you wrote the files into (and track full paths for cleanup), or keep the platform exclusion.

Copilot · 2026-03-11T13:00:44Z

src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void DifferentConfigSources_Merged_WithOverwrites()
        {


Same Apple mobile path issue as the earlier test: files may be created under Path.GetTempPath() but BuildConfig() reads from the default base path when only file names are provided. Re-enabling on iOS/tvOS without setting the builder base path will make this test fail to locate its inputs.

Copilot · 2026-03-11T13:00:44Z

...libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void AddUserSecrets_FindsAssemblyAttributeFromType()
        {


Re-enabling this test on iOS/tvOS can still fail because it depends on PathHelper.GetSecretsPathFromSecretsId finding a user profile location (APPDATA/HOME/SpecialFolder paths). Consider setting DOTNET_USER_SECRETS_FALLBACK_DIR to a temp directory during the test run (and restoring it) to avoid platform-specific failures, or keep the platform exclusion.

Copilot · 2026-03-11T13:00:45Z

...libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void AddUserSecrets_With_SecretsId_Passed_Explicitly()
        {


Re-enabling this test on iOS/tvOS may still fail if PathHelper.GetSecretsPathFromSecretsId cannot resolve a user-secrets root and throws InvalidOperationException. Consider forcing a writable user-secrets root for tests via DOTNET_USER_SECRETS_FALLBACK_DIR (temp directory) or keep the platform exclusion until the platform behavior is addressed.

Copilot · 2026-03-11T13:00:45Z

src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void OnLoadErrorWillBeCalledOnJsonParseError()
        {
            _fileSystem.WriteFile(Path.Combine(_basePath, "error.json"), @"{""JsonKey1"": ", absolute: true);


This test writes error.json to _basePath (AppContext.BaseDirectory) via absolute: true. Re-enabling it on iOS/tvOS (by removing the ActiveIssue) is likely to fail because the app base directory is generally not writable on those platforms. Use the existing _fileSystem.RootPath/_fileProvider for writable test files (or another temp location) and ensure the configuration builder is pointed at that path, or keep the platform exclusion.

mrek-msft · 2026-03-17T13:13:39Z

/azp run runtime-ioslike

azure-pipelines · 2026-03-17T13:13:54Z

Azure Pipelines successfully started running 1 pipeline(s).

mrek-msft · 2026-03-24T10:29:21Z

/azp help

azure-pipelines · 2026-03-24T10:29:28Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

mrek-msft · 2026-03-24T10:29:55Z

/azp list

azure-pipelines · 2026-03-24T10:30:02Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional runtime-nativeaot-outerloop runtime-coreclr superpmi-collect-test runtime-diagnostics runtime-interpreter runtime-report-green runtime-coreclr hardware-intrinsics runtime-libraries-interpreter runtime-vmr-validation

mrek-msft · 2026-03-24T10:35:57Z

/azp run runtime-ioslike
/azp run runtime-ioslikesimulator

azure-pipelines · 2026-03-24T10:36:04Z

No pipelines are associated with this pull request.

mrek-msft · 2026-03-24T10:36:34Z

/azp run runtime-ioslike, runtime-ioslikesimulator

azure-pipelines · 2026-03-24T10:36:47Z

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (3)

src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs:60

This test creates and writes a reference file under AppContext.BaseDirectory ("refs/.dll"). On iOS/tvOS AppContext.BaseDirectory is typically not writable (app bundle), which is what the removed platform exclusion was protecting. If the underlying issue is fixed and the exclusion can be removed, update the test to write into a writable temp directory (and ensure cleanup), or add an appropriate platform guard (e.g., temp base path / SkipOnPlatform) so it remains reliable on Apple mobile.

        [Fact]
        public void ResolveReferencePathsAcceptsNullCustomResolvers()
        {
            var library = TestLibraryFactory.Create();
            var assemblyPath = Path.Combine(AppContext.BaseDirectory, "refs", library.Name + ".dll");
            Directory.CreateDirectory(Path.GetDirectoryName(assemblyPath));
            File.WriteAllText(assemblyPath, "hello");

src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs:365

OnLoadErrorWillBeCalledOnJsonParseError writes "error.json" to _basePath, which is set to AppContext.BaseDirectory. That location is not reliably writable on iOS/tvOS, which is what the removed ActiveIssue skip was guarding. If you want this to run on Apple mobile, adjust the test to write under the DisposableFileSystem root (or another temp directory) and configure the builder base path/file provider accordingly, instead of using AppContext.BaseDirectory.

        [Fact]
        public void OnLoadErrorWillBeCalledOnJsonParseError()
        {
            _fileSystem.WriteFile(Path.Combine(_basePath, "error.json"), @"{""JsonKey1"": ", absolute: true);

            FileConfigurationProvider provider = null;

src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs:872

GetDefaultBasePathForSources writes test files to AppContext.BaseDirectory via _basePath. That directory is often read-only on iOS/tvOS, which is why this test had a platform exclusion. If this is meant to run on Apple mobile now, consider using a writable temp directory for the files and explicitly setting the builder base path/file provider so the test isn’t dependent on AppContext.BaseDirectory being writable.

        [Fact]
        public void GetDefaultBasePathForSources()
        {
            var builder = new ConfigurationBuilder();

            var jsonConfigFilePath = Path.Combine(_basePath, "test.json");
            var xmlConfigFilePath = Path.Combine(_basePath, "xmltest.xml");
            _fileSystem.WriteFile(jsonConfigFilePath, _jsonConfigFileContent, absolute: true);
            _fileSystem.WriteFile(xmlConfigFilePath, _xmlConfigFileContent, absolute: true);

Copilot · 2026-03-24T10:39:07Z

src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void DifferentConfigSources_Merged_WithOverwrites()
        {
            var config = BuildConfig();


On Apple mobile, this fixture writes its config files to Path.GetTempPath(), but BuildConfig() uses relative paths without calling SetBasePath / configuring a file provider. That means the builder will typically look under the default base path (often AppContext.BaseDirectory), not the temp directory where the files were written, which is what the removed iOS/tvOS exclusion was guarding. If the exclusion is being removed, update the test to set the builder base path to the same directory used for file creation and ensure cleanup deletes the full paths (not just file names).

Copilot · 2026-03-24T10:39:07Z

...libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void AddUserSecrets_FindsAssemblyAttributeFromType()
        {


These tests depend on PathHelper.GetSecretsPathFromSecretsId(), which throws if no user-secrets root can be determined from APPDATA/HOME/GetFolderPath. The removed iOS/tvOS exclusion likely existed because those values aren’t reliably available/usable on Apple mobile test environments. If you want this test enabled on iOS/tvOS, make it self-contained by setting DOTNET_USER_SECRETS_FALLBACK_DIR to a temp directory for the duration of the test (and restoring it), so the secrets path is always resolvable and writable.

Copilot · 2026-03-24T10:39:07Z

...libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs

        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
        public void AddUserSecrets_With_SecretsId_Passed_Explicitly()
        {


These tests depend on PathHelper.GetSecretsPathFromSecretsId(), which throws if no user-secrets root can be determined from APPDATA/HOME/GetFolderPath. The removed iOS/tvOS exclusion likely existed because those values aren’t reliably available/usable on Apple mobile test environments. If you want this test enabled on iOS/tvOS, make it self-contained by setting DOTNET_USER_SECRETS_FALLBACK_DIR to a temp directory for the duration of the test (and restoring it), so the secrets path is always resolvable and writable.

mrek-msft added 2 commits March 3, 2026 14:32

try remove test exclusions

6fac028

try broke test

1ce98a6

mrek-msft added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 9, 2026

Copilot AI review requested due to automatic review settings March 9, 2026 14:15

mrek-msft added the NO-REVIEW Experimental/testing PR, do NOT review it label Mar 9, 2026

dotnet-policy-service bot assigned mrek-msft Mar 9, 2026

github-actions bot added the area-Extensions-Configuration label Mar 9, 2026

Copilot started reviewing on behalf of mrek-msft March 9, 2026 14:16 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

comment out temporary dead code

5e921d6

build-analysis bot mentioned this pull request Mar 10, 2026

XHarness DevToolsActivePort file doesn't exist #124438

Closed

Remove experimental code and remove remaining ActiveIssues

e3c3ed3

Copilot AI review requested due to automatic review settings March 11, 2026 12:54

Copilot started reviewing on behalf of mrek-msft March 11, 2026 12:55 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

mrek-msft closed this Mar 17, 2026

mrek-msft reopened this Mar 17, 2026

This was referenced Mar 17, 2026

iOS.Device test WorkItemExecutions #122874

Open

Crst Level violation: Can't take level 17 lock CrstLoaderAllocatorReferences #125638

Closed

Copilot AI mentioned this pull request Mar 17, 2026

Partially revert #125574: restore fixed buffers in networking P/Invoke structs to fix Crst level violation #125664

Closed

Merge branch 'main' into dev/mrek/mecfg-test-act-is-removal-ios-tvos

eff8fad

Merge branch 'main' into dev/mrek/mecfg-test-act-is-removal-ios-tvos

c51a8cd

Copilot AI review requested due to automatic review settings March 24, 2026 10:34

Copilot started reviewing on behalf of mrek-msft March 24, 2026 10:35 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Conversation

mrek-msft commented Mar 9, 2026

Uh oh!

dotnet-policy-service bot commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

mrek-msft commented Mar 17, 2026

Uh oh!

azure-pipelines bot commented Mar 17, 2026

Uh oh!

mrek-msft commented Mar 24, 2026

Uh oh!

azure-pipelines bot commented Mar 24, 2026

Uh oh!

mrek-msft commented Mar 24, 2026

Uh oh!

azure-pipelines bot commented Mar 24, 2026

Uh oh!

mrek-msft commented Mar 24, 2026

Uh oh!

azure-pipelines bot commented Mar 24, 2026

Uh oh!

mrek-msft commented Mar 24, 2026

Uh oh!

azure-pipelines bot commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants