fix(ai template): avoid nullable filenameFilter tool schema for Ollama#7368
Open
SergioChan wants to merge 1 commit intodotnet:mainfrom
Open
fix(ai template): avoid nullable filenameFilter tool schema for Ollama#7368SergioChan wants to merge 1 commit intodotnet:mainfrom
SergioChan wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AI Chat Web C# project template to avoid generating a nullable filenameFilter tool parameter schema, which currently breaks OllamaSharp’s tool mapper during function/tool serialization.
Changes:
- Change the
SearchAsynctool parameterfilenameFilterfromstring? = nullto non-nullablestring = ""to prevent a nullable JSON schematype(array) from being emitted. - Preserve existing search behavior by continuing to treat empty string as “no filter / search all files”.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SearchAsync'sfilenameFilterparameter in the AI Chat Web template from nullable string to non-null string defaulting to emptytype: "string"Testing
string filenameFilter = ""signature atChat.razor(single-line scoped change)dotnet buildin this environment because thedotnetCLI is not installed (dotnet: command not found)Related
Fixes #7350