Merged
Conversation
This prevents backwards-incompatible devDependencies from breaking the build.
I'd prefer node 8 for checking backwards-compatibility, but our devDependencies really won't have it.
…)" This reverts the previous two commits, because I learned the hard way that actions cannot be composed out of other actions.
On other branches, CI will either trigger anyway because of the PR event, or be redundant because of the upcoming CD workflow (on prepublish and gh-pages).
jgonggrijp
changed the title
Contributor
Author
|
Side remark: the |
Contributor
Author
|
Friendly reminder @joshuacc |
This was referenced Dec 13, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of the pull request is to review the design of the procedure. While the CI part is confirmed to work, I can test the CD part only after merging into
master(I attempted testing in #235, but the workflows weren't triggered because I created them manually and they aren't onmasteryet).Note that the
DEPLOYING.mdlooks more complicated than it is. I went into details and covered all the failure scenarios I could think of, on the assumption that it is better to document a bit too much than too little. I'm open to being corrected on that count.