buildx: remove "-docker" suffix from version#552
Closed
thaJeztah wants to merge 1 commit intodocker:masterfrom
Closed
buildx: remove "-docker" suffix from version#552thaJeztah wants to merge 1 commit intodocker:masterfrom
thaJeztah wants to merge 1 commit intodocker:masterfrom
Conversation
When building the CLI plugin, we were adding a "-docker" suffix. It's a bit unclear if there was a specific reason for this (possibly to differentiate between builds from GitHub and builds that are part of the CLI? Initially, the version had a `-tp-docker` prefix (where `-tp` was used to indicate it was still experimental); this prefix was removed in commit 0b45cce /usr/libexec/docker/cli-plugins/docker-buildx docker-cli-plugin-metadata { "SchemaVersion": "0.1.0", "Vendor": "Docker Inc.", "Version": "v0.5.1-docker", "ShortDescription": "Build with BuildKit" } This patch removes the `-docker` suffix from the version string. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@tonistiigi @chris-crone PTAL |
Member
|
SGTM but maybe @tonistiigi has context that I don't |
Member
|
It was added to determine the releases that required experimental to be turned on. Github releases of Buildx never required it. Maybe we should keep this until the builds here do not build with the Dockerfile from the upstream repo and define their own build scripts so if there is an issue reported we can see what script made the binary. |
Member
Author
|
Superseded by #654, which also removed the suffix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the CLI plugin, we were adding a "-docker" suffix. It's a bit
unclear if there was a specific reason for this (possibly to differentiate
between builds from GitHub and builds that are part of the CLI?
Initially, the version had a
-tp-dockerprefix (where-tpwas used toindicate it was still experimental); this prefix was removed in commit
0b45cce (#490)
This patch removes the
-dockersuffix from the version string.