Fix potential nil pointer dereference when checking container state in Remove #13556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
inspected.Statebefore accessinginspected.State.Runningin theRemovefunctionProblem
In
pkg/compose/remove.go:67, the code accessesinspected.State.Runningwithout first checking ifinspected.Stateis nil:While Docker containers typically always have State populated, this is inconsistent with nil checks done elsewhere in the codebase and could cause a panic in edge cases (race conditions, unusual Docker states, or API changes).
Solution
Add a nil check consistent with the pattern used elsewhere in the codebase:
pkg/compose/convergence.go:836-ctr.State != nil && ctr.State.Statuspkg/compose/convergence.go:862-ctr.State != nil && ctr.State.Statuspkg/compose/monitor.go:150-inspect.State != nil && (inspect.State.Restarting || ...)pkg/compose/ps.go:70-if inspect.State != nil {The fix adds a nil check that treats containers with nil State as "stopped" (which is the safe default for the Remove operation).