test rmi -f returns success#567
Closed
andrewhsu wants to merge 1 commit intodocker:masterfrom
andrewhsu:rmi-f
Closed
test rmi -f returns success#567andrewhsu wants to merge 1 commit intodocker:masterfrom andrewhsu:rmi-f
andrewhsu wants to merge 1 commit intodocker:masterfrom
andrewhsu:rmi-f
Conversation
Signed-off-by: Andrew Hsu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 49.4% 49.41% +0.01%
==========================================
Files 208 208
Lines 17159 17159
==========================================
+ Hits 8477 8479 +2
+ Misses 8249 8247 -2
Partials 433 433 |
dnephin
suggested changes
Sep 28, 2017
| golden.Assert(t, result.Stderr(), "run-attached-from-remote-and-remove.golden") | ||
| } | ||
|
|
||
| func TestForceRemoveImage(t *testing.T) { |
Contributor
There was a problem hiding this comment.
We already have test coverage for that here in the unit test suite: https://github.com/docker/cli/blob/master/cli/command/image/remove_test.go#L71-L78
Following https://github.com/docker/cli/blob/master/TESTING.md#guidelines I don't think we need an e2e test for the force flag.
I unit test for a successful docker rmi would be good, but it would go in the e2e/image package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added
e2etest to verifydocker rmi -freturns unix code success always because-f.- How I did it
At my desk.
- How to verify it
- Description for the changelog
N/A
- A picture of a cute animal (not mandatory but encouraged)
🐛