refactor: replace deprecated nvim_buf_get/set_option with vim.bo#5
Merged
dlyongemallo merged 1 commit intomainfrom Feb 6, 2026
Merged
refactor: replace deprecated nvim_buf_get/set_option with vim.bo#5dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors Diffview’s buffer option handling to avoid deprecated nvim_buf_get_option / nvim_buf_set_option calls by using Neovim’s Lua option interface (vim.bo) instead.
Changes:
- Replace buffer option writes in file/panel buffer creation with
vim.bo[bufnr][opt] = value. - Replace buffer
modifiableget/set in the renderer withvim.bo[bufid].modifiable.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/vcs/file.lua | Switches buffer-local option assignment for diff buffers and the NULL buffer to vim.bo. |
| lua/diffview/ui/panel.lua | Switches panel buffer option assignment to vim.bo. |
| lua/diffview/renderer.lua | Uses vim.bo to temporarily toggle modifiable during render updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.