fix(keymaps): register commit_log_panel keymaps in init_buffer instead of init#1
Merged
dlyongemallo merged 1 commit intomainfrom Feb 5, 2026
Merged
fix(keymaps): register commit_log_panel keymaps in init_buffer instead of init#1dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
…d of init Fixes bug introduced in 1b386ce which caused Esc to close any diffview window.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the commit_log_panel keymap registration by moving the keymap setup from the init method to the init_buffer method. This ensures that keymaps are registered only when the buffer is actually created and self.bufid is available.
Changes:
- Moved keymap registration from
init()toinit_buffer()in CommitLogPanel - Kept the close event listener in
init()where it belongs - Added proper call to parent class's
init_buffer()method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.