feat: candid interface compatibility check#390
Open
adamspofford-dfinity wants to merge 5 commits intomainfrom
Open
feat: candid interface compatibility check#390adamspofford-dfinity wants to merge 5 commits intomainfrom
adamspofford-dfinity wants to merge 5 commits intomainfrom
Conversation
lwshang
approved these changes
Feb 25, 2026
raymondk
requested changes
Feb 25, 2026
Contributor
There was a problem hiding this comment.
As I understand it, a icp deploy will attempt to install all the canisters in parallel.
If one of the canisters has an incompatible interface only it will fail to install and the rest will succeed.
I thought it would be better to:
- check all the canister interfaces in parallel, abort if one of them doesn't pass the check
- install all the canisters
We could do this by making an "check candid interface" operation and making the deploy and install commands to the check, then the install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.