fix: make local_name in corebluetooth more descriptive #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyoyuppe
force-pushed
the
extract_adv_local_name
branch
2 times, most recently
from
6ccfc7f to
336263d
Compare
yuyoyuppe
force-pushed
the
extract_adv_local_name
branch
2 times, most recently
from
8d6b34f to
dfcc0a6
Compare
Contributor
Author
|
This might break people relying on an exact device name, so would be worth mentioning in Release notes. |
qwandor
reviewed
Jun 6, 2024
yuyoyuppe
force-pushed
the
extract_adv_local_name
branch
from
dfcc0a6 to
f5e6d76
Compare
qwandor
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
Corebluetooth stack discovers my BTLE device with a very generic name while having a correct name on Windows and on Android.
Change description
This PR implements the fix suggested in #334 and extends the event_driven_discovery example to print peripheral names.
Concerns
I'm not sure it's the best approach to merge
Advertisement Data[Local Name]and peripheral names when they're both present, so I'm open for better ideas.