Skip to content

Use libtremolo: ARM-optimized implementation of VorbisCodec#1

Merged
devgianlu merged 4 commits intodevgianlu:masterfrom
funtax:libtremolo-decoder
Apr 25, 2021
Merged

Use libtremolo: ARM-optimized implementation of VorbisCodec#1
devgianlu merged 4 commits intodevgianlu:masterfrom
funtax:libtremolo-decoder

Conversation

@funtax
Copy link
Collaborator

@funtax funtax commented Apr 21, 2021

As Vorbis-/OGG-decoding via jorbis is a CPU-intensive job you might use the optimized version of libtremolo(NDK).
It's used in my app since ~2016 and should work very stable.

@devgianlu devgianlu added the enhancement New feature or request label Apr 21, 2021
@devgianlu devgianlu mentioned this pull request Apr 25, 2021
@devgianlu
Copy link
Owner

devgianlu commented Apr 25, 2021

@funtax I tried running the build, but it's complaining about ndk-build.cmd missing. Nevermind, I don't have NDK installed.

@devgianlu
Copy link
Owner

devgianlu commented Apr 25, 2021

Having to depend on the entire librespot-player module isn't optimal. I should probably change it like I did for the sink, but it'd much more complicated. We'll see.

@devgianlu devgianlu merged commit 9f4f361 into devgianlu:master Apr 25, 2021
@mitschwimmer
Copy link
Collaborator

@devgianlu can you build tremolo now? I get an error while doing, seems to be the same as here: Suvitruf/Android-ndk#3

@devgianlu
Copy link
Owner

@devgianlu can you build tremolo now? I get an error while doing, seems to be the same as here: Suvitruf/Android-ndk#3

The PR comes with binaries already so I simply commented out the build command and it runs fine.

@mitschwimmer
Copy link
Collaborator

You seem me relieved 😅

@funtax
Copy link
Collaborator Author

funtax commented Apr 25, 2021

Hey there, i will try to give feedback on this later. Cannot see here if these tellOgg, readOgg etc. Have been removed, but they are required by the native parts.

@devgianlu
Copy link
Owner

I have noticed that after merging. I have added them back on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants