Merged
Conversation
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Labels should also be removed from the |
hardcoretime
requested changes
Feb 19, 2026
images/virtualization-artifact/pkg/controller/service/restorer/restorers/vm_restorer.go
Outdated
Show resolved
Hide resolved
eofff
force-pushed
the
chore/vmop/do-not-restore-labels-on-cloned-vm
branch
from
5053665 to
3931b15
Compare
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
…/restorers/vm_restorer.go Co-authored-by: Roman Sysoev <36233932+hardcoretime@users.noreply.github.com> Signed-off-by: Valeriy Khorunzhin <b1kapb999@gmail.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
eofff
force-pushed
the
chore/vmop/do-not-restore-labels-on-cloned-vm
branch
from
a16553e to
d016e30
Compare
hardcoretime
previously approved these changes
Feb 19, 2026
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
prismagod
approved these changes
Feb 20, 2026
hardcoretime
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not clone labels on VM by restore virtual machine operation.
Why do we need it, and what problem does it solve?
Cloning labels may cause issues with incoming traffic routed by services.
Checklist
Changelog entries