This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Better check for node.js context#33
Merged
dcodeIO merged 1 commit intodcodeIO:masterfrom Jul 29, 2015
kethinov:master
Merged
Conversation
dcodeIO
added a commit
that referenced
this pull request
Jul 29, 2015
Better check for node.js context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for
windowwill produce a false negative in some contexts, such as iron-node (I tested this, it fails) and possibly NW.js (untested, but I suspect it might also fail) which provide both node features likerequire,module, andprocess, as well aswindow.This tweak checks more explicitly for things that are exclusive to node and should not produce a false negative if node features and
windoware both present.