Add hypot specification for computing the square root of the sum of squares#703
Merged
rgommers merged 4 commits intodata-apis:mainfrom Feb 21, 2024
Merged
Add hypot specification for computing the square root of the sum of squares#703rgommers merged 4 commits intodata-apis:mainfrom
hypot specification for computing the square root of the sum of squares#703rgommers merged 4 commits intodata-apis:mainfrom
Conversation
17 tasks
Contributor
|
I am a bit concerned about mentioning subnormal here. In CuPy we always set the compiler flag |
Contributor
|
Q: I forgot what conclusion we had on this API, @kgryte do we plan to target v2023? |
Contributor
Author
|
@leofang I've added a note concerning subnormal behavior and the fact that actual hardware support may vary. Does this allay your concerns? |
leofang
approved these changes
Feb 21, 2024
Member
|
Great, looks like everyone is happy now - let's hit the green button. Thanks @kgryte & reviewers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
hypot#544 by adding a specification for computing the square root of the sum of squares.+-infinity, the result is infinity, regardless of whether the other operand isNaN. Intentionally, this deviates from a naivesqrt(x**2 + y**2)implementation.sqrtin requiring floating-point data types. The guidance uses "should", not "must", to allow implementations to support non-floating-point data types. The reason for the floating-point restriction is that the output data type must be a real-valued floating-point data type and promoting from, e.g., an integral to a floating-point data type is implementation-defined. For defined promotion semantics, a consumer should provide input arrays having floating-point data types.