Merged
Conversation
rgommers
requested changes
Apr 10, 2023
Member
rgommers
left a comment
There was a problem hiding this comment.
I'm unsure on what was the initial criteria for the emojis for each contributor, do we have a preference?
This is a matter of judgement, you can't automate it. Ideas, Planning, & Feedback seems reasonable for most folks, when they've contributed to discussions/decisions. There are others possible of course; this should be clear from existing entries.
(note: all the contributors added in this PR are people that have at least 1 commit in this repo)
Can you please check open PRs too? And I'll send you a few more on Slack.
Member
Author
|
The last commit included people that opened issues in both the array-api and testing repos. I'm waiting for one confirmation and after that this PR will be ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #516
Questions