PR: Transform manipulation_functions.md to rst#354
Merged
kgryte merged 2 commits intodata-apis:mainfrom Jan 31, 2022
Merged
Conversation
26 tasks
Member
|
I think this just has the question about the notes (#345 (comment)). It looks good otherwise. |
Member
|
The notes directives still need to be updated here. |
kgryte
approved these changes
Jan 31, 2022
Contributor
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
LGTM. As the notes directives have been updated, will merge. Any additional changes can be performed in subsequent PRs.
kgryte
added a commit
to kgryte/array-api
that referenced
this pull request
Feb 5, 2026
In data-apis#354, a regression was introduced which reverted a change to the signature of `expand_dims`. Namely, the `axis` argument should not have been made optional and should not have had a default value. Ref: data-apis#331 Ref: data-apis#354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the manipulation functions markdown into rst
Ref: #283