Add a note on adding complex64/128 in a future version#105
Merged
rgommers merged 3 commits intodata-apis:mainfrom Jan 13, 2021
Merged
Add a note on adding complex64/128 in a future version#105rgommers merged 3 commits intodata-apis:mainfrom
rgommers merged 3 commits intodata-apis:mainfrom
Conversation
This introduces a new "Future extension" admonition, which uses the MyST "colon fence" (requires a newer version of MyST). Closes data-apisgh-102
leofang
reviewed
Jan 5, 2021
Contributor
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
Thank you, @rgommers. Sorry for my delayed response. The rendered webpage and most of text changes LGTM.
For the complex dtype itself, I wonder if we can make a stronger commitment for the path forward?
- Say that it will be included in the next version of Array API, not just a future one
- Lay out the expected type conversion diagram/table as discussed in #102 (and, ofc, mark it clearly that this conversion is to be expected in the next version) to strengthen the impression that it's been considered and evaluated and we just need time to keep everyone on the same page
What do you think?
Co-authored-by: Leo Fang <leofang@bnl.gov>
Member
Author
|
Thanks Leo, that sounds fine to me - I committed your suggestion and will add the diagram later this week. |
Member
Author
|
Updated to:
|
rgommers
force-pushed
the
dtypes-complex
branch
from
34f7508 to
b36720a
Compare
Member
Author
argh. fixed now:
Will do something about font sizes whenever we get back to really adding complex dtypes, can't be bothered with resizing all those circles for a slightly more uniform look now. |
Member
Author
|
Done. Thanks for reviewing! |
This was referenced Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also cleans up all the notes in the Data Types section, which were a bit messy and had some duplication.
And it introduces a new "Future extension" admonition, which uses the MyST "colon fence" (requires a newer version of MyST):
Closes gh-102