convert all formal to named parameters produde bad code

[stephane-archer]

class ButtonsSection extends StatelessWidget {
  final FCPLibrary _finalCutLibrary;
  final Future<int> _renderFilesSize;
  final Future<int> _proxyMediaSize;
  final Future<int> _optimizedMediaSize;
  final Future<int> _opticalFLowFilesSize;
  final Future<bool> _hasExternalSymlinks;

  const ButtonsSection(
      this._finalCutLibrary,
      this._renderFilesSize,
      this._proxyMediaSize,
      this._optimizedMediaSize,
      this._opticalFLowFilesSize,
      this._hasExternalSymlinks,
      {super.key});

  @override
  Widget build(BuildContext context) {
    ...
  }
}

convert all formal to named parameters produde bad code

class ButtonsSection extends StatelessWidget {
  final FCPLibrary _finalCutLibrary;
  final Future<int> _renderFilesSize;
  final Future<int> _proxyMediaSize;
  final Future<int> _optimizedMediaSize;
  final Future<int> _opticalFLowFilesSize;
  final Future<bool> _hasExternalSymlinks;

  const ButtonsSection(
      {required this._finalCutLibrary,
      required this._renderFilesSize,
      required this._proxyMediaSize,
      required this._optimizedMediaSize,
      required this._opticalFLowFilesSize,
      required this._hasExternalSymlinks,
      super.key});

  @override
  Widget build(BuildContext context) {
...
  }
}

expected code:

class ButtonsSection extends StatelessWidget {
  final FCPLibrary _finalCutLibrary;
  final Future<int> _renderFilesSize;
  final Future<int> _proxyMediaSize;
  final Future<int> _optimizedMediaSize;
  final Future<int> _opticalFLowFilesSize;
  final Future<bool> _hasExternalSymlinks;

  const ButtonsSection(
      {required FCPLibrary finalCutLibrary,
      required Future<int> renderFilesSize,
      required Future<int> proxyMediaSize,
      required Future<int> optimizedMediaSize,
      required Future<int> opticalFLowFilesSize,
      required Future<bool> hasExternalSymlinks,
      super.key})
      : _hasExternalSymlinks = hasExternalSymlinks,
        _opticalFLowFilesSize = opticalFLowFilesSize,
        _optimizedMediaSize = optimizedMediaSize,
        _proxyMediaSize = proxyMediaSize,
        _renderFilesSize = renderFilesSize,
        _finalCutLibrary = finalCutLibrary;

  @override
  Widget build(BuildContext context) {
    ...
  }
}

[bwilkerson]

Interesting.

This behavior will no longer be a problem when the 'private-named-parameters' feature is released. When we fix this we should leave the current behavior when the feature is enabled and only change the behavior when the feature is not enabled.

@munificent