inline Ambiguous return value.

[stephane-archer]

  Future<Iterable<String>?> _filePickFCPLibraries( // try to inline _filePickFCPLibraries
      AppLocalizations appLocalizations) async {
    List<MacosFilePickerPath>? selectedItems = await MacosFilePicker().pick(
      MacosFilePickerMode.fileAndFolder,
      allowsMultiple: true,
      allowedFileExtensions: ["fcpbundle"],
      dialogTitle: appLocalizations.filePickerInstruction,
    );
    if (selectedItems == null) {
      return null;
    }
    return selectedItems.map(
      (selectedItem) {
        return selectedItem.path;
      },
    );
  }

  Future<void> _onImportLibraries(
      BuildContext context, AppLocalizations appLocalization) async {
    await _importNewFinalCutLibraries(
      context: context,
      getSelectedPath: () {
        return _filePickFCPLibraries(appLocalization);
      },
    );
  }

Ambiguous return value.

[FMorschel]

What Dart version are you using, @stephane-archer? I could not reproduce this on the latest master, but it seems a lot like #60160 (which should have landed on 3.8, see the latest tag on this commit 8f79645).

[stephane-archer]

@FMorschel Dart 3.10.4

[FMorschel]

Oh, I know what I did wrong when testing this. I made my list non-null. The:

if (selectedItems == null) {
  return null;
}

Section followed by a second return makes this ambiguous.

Maybe we could do a better job here and look for the return statements at the initial check, @bwilkerson? This way, we would not suggest this refactoring when we can't do it.

CC @DanTup