Fix caching for insert queries with fragments#177
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #177 +/- ##
============================================
+ Coverage 95.25% 95.27% +0.02%
- Complexity 1838 1839 +1
============================================
Files 130 130
Lines 5075 5077 +2
============================================
+ Hits 4834 4837 +3
+ Misses 241 240 -1 ☔ View full report in Codecov by Sentry. |
roxblnfk
approved these changes
Mar 28, 2024
This was referenced Mar 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's was changed
The caching of insert queries with fragments has been fixed.
The hash of the cached query did not take into account the number of fragments used in the query. That is, if in the first query we use two fragments, its hash is generated and we save the generated query:
Then comes a query where the number of fragments is different; its generated hash will be the same, but the generated SQL will be different:
Another situation may occur where the number of fragments is the same, but their content is different. This has been fixed. Now the query hash takes into account the fragments and their content.
Closes: #176