Add name.variable and value.variable#2219
Merged
AndreasArvidsson merged 3 commits intomainfrom Feb 3, 2024
Merged
Conversation
Member
|
I don't see that you're actually distinguishing between assignment and declaration here? You're renaming assignment to variable. Shouldn't we just keep assignment and add variable(or declaration) as an extra facet? |
Member
Author
|
For name and value I did keep assignment, and added declaration as additional. Maybe you missed it? For type I just renamed assignment because I don't think type makes sense for assignments |
Member
|
Ah right. |
AndreasArvidsson
approved these changes
Feb 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's worth distinguishing between an assignment (
foo = bar) and a variable declarateion (const foo = bar) to make it clear we want to support both. I think the namename.variableandvalue.variableare clear enough and consistent withname.functionChecklist