Public get text action by AndreasArvidsson · Pull Request #2069 · cursorless-dev/cursorless

AndreasArvidsson · 2023-11-29T08:36:29Z

Fixes #452

Checklist

I have added tests
I have updated the docs and cheatsheet
I have not broken the cheatsheet

pokey

we should prob have api test for this, no?

AndreasArvidsson · 2023-11-30T19:04:08Z

we should prob have api test for this, no?

Extension side we actually have multiple tests for this already
eg
https://github.com/cursorless-dev/cursorless/blob/a723b253c61106dfc7e32638e2d20b53292d17a0/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/actions/getTextAir.yml
https://github.com/cursorless-dev/cursorless/blob/a723b253c61106dfc7e32638e2d20b53292d17a0/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/actions/findVest.yml

pokey · 2023-11-30T19:57:50Z

Yes but I mean the talon-side api introduced by this PR. We have tests for our other talon-side APIs

AndreasArvidsson · 2023-12-01T03:12:30Z

True. Test added.

cursorless-talon/src/actions/get_text.py

…s into get_text_action

pokey

Last minor comments

docs/user/customization.md

cursorless-talon/src/actions/get_text.py

Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>

cursorless-talon/src/actions/get_text.py

pokey

made some changes:

Stopped using the public api for our internal impl. I'm not in love with coupling those
Switched no_decorations to silent. Double-negatives confuse me, so I prefer to avoid them if possible
I made all args to our function explicit. If we have the decorations flag reversed between talon api and cursorless api, the only way to make heads or tails I think is to just be super explicit and pass them every time

Feel free to merge if you're happy

AndreasArvidsson · 2023-12-19T07:21:01Z

I'm not in love with the argument silent. It's much less descriptive than no_decorations.

pokey · 2023-12-19T11:23:49Z

I'm not in love with the argument silent. It's much less descriptive than no_decorations.

I agree. But I also really don't like double negatives (ie no_decorations = False). Any better ideas? Chatgpt suggests

omit_decorations
hide_decorations
suppress_decorations

cc/ @josharian

AndreasArvidsson · 2023-12-19T12:58:06Z

I'm not in love with the argument silent. It's much less descriptive than no_decorations.

I agree. But I also really don't like double negatives (ie no_decorations = False). Any better ideas? Chatgpt suggests
* `omit_decorations`

* `hide_decorations`

* `suppress_decorations`
cc/ @josharian

hide_decorations sounds reasonable

pokey · 2023-12-19T14:09:07Z

Ok made some final tweaks and confirmed talon tests work locally. I'll give you a chance for a quick look in case I did anything dumb; merge if happy

cursorless-talon-dev/src/cursorless_test.talon

packages/cursorless-engine/src/test/fixtures/talonApi.fixture.ts

cursorless-talon-dev/src/cursorless_test.talon

Fixes #452 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>

Fixes cursorless-dev#452 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>

Made public get text action

4d1b83d

AndreasArvidsson requested a review from pokey as a code owner November 29, 2023 08:36

AndreasArvidsson changed the title ~~Made public get text action~~ Public get text action Nov 29, 2023

pokey reviewed Nov 30, 2023

View reviewed changes

Added spoken form tests

16e26f5

clean up

7436c88

pokey reviewed Dec 1, 2023

View reviewed changes

cursorless-talon/src/actions/get_text.py Show resolved Hide resolved

AndreasArvidsson and others added 4 commits December 2, 2023 09:40

Split get text action into two separate actions

84baff0

[pre-commit.ci lite] apply automatic fixes

d166bd4

Remove unused import

43e5f05

Merge branch 'get_text_action' of github.com:cursorless-dev/cursorles…

48c73a6

…s into get_text_action

pokey reviewed Dec 4, 2023

View reviewed changes

docs/user/customization.md Outdated Show resolved Hide resolved

cursorless-talon/src/actions/get_text.py Outdated Show resolved Hide resolved

cursorless-talon/src/actions/get_text.py Outdated Show resolved Hide resolved

AndreasArvidsson and others added 6 commits December 4, 2023 14:25

Update docs/user/customization.md

8da2961

Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>

invert boolean argument

24a4612

Fixed

46d2f48

Update

ab8b436

Flip boolean

a690090

Update fixtures

b717b32

pokey reviewed Dec 5, 2023

View reviewed changes

cursorless-talon/src/actions/get_text.py Show resolved Hide resolved

Update phrasing

99d7964

pokey reviewed Dec 6, 2023

View reviewed changes

cursorless-talon/src/actions/get_text.py Outdated Show resolved Hide resolved

AndreasArvidsson and others added 2 commits December 7, 2023 04:21

work work

a4bb31f

[pre-commit.ci lite] apply automatic fixes

216b7f9

AndreasArvidsson requested a review from pokey December 16, 2023 07:48

pokey added 3 commits December 18, 2023 18:16

Merge branch 'main' into get_text_action

c518b9b

Tweaks

4556f10

fixes

5d3d7f2

pokey added 3 commits December 18, 2023 18:21

fix

1953bb1

Fix talon tests

10252a4

docs

3887fbb

pokey approved these changes Dec 18, 2023

View reviewed changes

pokey added 2 commits December 19, 2023 14:06

fixes

cf8f1b4

Update docs

e26c816

Update doc string#

2f7985c

AndreasArvidsson commented Dec 19, 2023

View reviewed changes

cursorless-talon-dev/src/cursorless_test.talon Show resolved Hide resolved

AndreasArvidsson commented Dec 19, 2023

View reviewed changes

packages/cursorless-engine/src/test/fixtures/talonApi.fixture.ts Outdated Show resolved Hide resolved

AndreasArvidsson commented Dec 19, 2023

View reviewed changes

cursorless-talon-dev/src/cursorless_test.talon Outdated Show resolved Hide resolved

pokey added 4 commits December 19, 2023 14:37

Fixes

258570b

Merge branch 'main' into get_text_action

fcdf675

Merge branch 'main' into get_text_action

4900e1a

fix

c7d20de

pokey enabled auto-merge December 19, 2023 14:49

pokey added this pull request to the merge queue Dec 19, 2023

Merged via the queue into main with commit 7341d0f Dec 19, 2023

pokey deleted the get_text_action branch December 19, 2023 15:04

Uh oh!

Conversation

AndreasArvidsson commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

pokey left a comment

Choose a reason for hiding this comment

Uh oh!

AndreasArvidsson commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pokey commented Nov 30, 2023

Uh oh!

AndreasArvidsson commented Dec 1, 2023

Uh oh!

Uh oh!

pokey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pokey left a comment

Choose a reason for hiding this comment

Uh oh!

AndreasArvidsson commented Dec 19, 2023

Uh oh!

pokey commented Dec 19, 2023

Uh oh!

AndreasArvidsson commented Dec 19, 2023

Uh oh!

pokey commented Dec 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AndreasArvidsson commented Nov 29, 2023 •

edited

Loading

AndreasArvidsson commented Nov 30, 2023 •

edited

Loading