Conversation
pokey
force-pushed
the
destination-talon
branch
from
793da45 to
692575b
Compare
|
@pokey All tests are passing at my end. I checked and the |
|
Yep they were working fine for me too last I checked 👍. I just realised why we have that unused context arg: we were using it for experimental snippet stuff and then removed that tag. I guess we might use it for experimental stuff in the future, but I'm also fine with just removing it for now 🤷♂️ |
|
I think we can remove it for now and it's easy enough to readd if we need it in the future. |
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Good stuff! Made a bunch of minor tweaks, and left comments for the ones I wasn't sure about. I'm happy to make the changes or let you do it; either way
|
Re removing |
Sounds good |
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
|
@pokey Updated with requested changes |
| if hasattr(m, "cursorless_insertion_mode_to"): | ||
| words = m._unmapped | ||
| actions.app.notify( | ||
| f"'{' '.join(words)}' is deprecated. Please just say '{words[-1]}'" |
There was a problem hiding this comment.
Not sure whether it's worth fixing, but this doesn't correctly handle the case where they have more than one word in their spoken form for "before" or "after", right?
There was a problem hiding this comment.
Exactly. This will just utilize the words they used for this phrase. Which I think is probably good enough.
There was a problem hiding this comment.
Right but eg if they have "prior to" as their spoken form for before, then if they say "to prior to", it will say
'to prior to' is deprecated. Please just say 'to'
correct? I guess we can live with that; I have to imagine remapping "before" to a two-word modifier is exceedingly rare, if anyone has done it at all
There was a problem hiding this comment.
You are probably right. Should be very rare
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Good stuff! I think it's time to ship it
Depends on #1637 - Fixes #725 - Partially addresses #1440 - Fixes #1319 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] Update cheatsheet spoken form defaults - [x] Manually test the various snippet terms - [x] Manually test the snippet apis - [ ] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Depends on cursorless-dev#1637 - Fixes cursorless-dev#725 - Partially addresses cursorless-dev#1440 - Fixes cursorless-dev#1319 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] Update cheatsheet spoken form defaults - [x] Manually test the various snippet terms - [x] Manually test the snippet apis - [ ] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
2 participants
Depends on #1637
Checklist