Skip to content

Upgrade typescript and use it for vscode TS server #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pokey wants to merge 1 commit into from
Closed

Upgrade typescript and use it for vscode TS server #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,7 @@
"pojo",
"subword"
],
"files.eol": "\n"
"files.eol": "\n",
"typescript.enablePromptUseWorkspaceTsdk": true,
"typescript.tsdk": "node_modules/typescript/lib"
}
2 changes: 1 addition & 1 deletion cursorless-nx/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"react-test-renderer": "18.1.0",
"ts-jest": "27.1.4",
"ts-node": "10.8.2",
"typescript": "4.7.4",
"typescript": "4.8.3",
Copy link
Member

@auscompgeek auscompgeek Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to pin the minor version instead of the patch version.

Suggested change
"typescript": "4.8.3",
"typescript": "~4.8.3",

Although I guess I can make the same note about all the version pinning happening in this file 😕

"typescript-plugin-css-modules": "^3.4.0"
},
"dependencies": {
Expand Down
12 changes: 6 additions & 6 deletions docs-site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@
},
"devDependencies": {
"docusaurus-plugin-typedoc": "^0.17.2",
"typedoc": "^0.22.10",
"typedoc-plugin-markdown": "^3.11.9",
"typedoc-plugin-mdn-links": "^1.0.4",
"typedoc-plugin-missing-exports": "^0.22.6",
"typedoc-plugin-rename-defaults": "^0.4.0",
"typescript": "4.6.3"
"typedoc": "^0.23.14",
"typedoc-plugin-markdown": "^3.13.6",
"typedoc-plugin-mdn-links": "^1.0.6",
"typedoc-plugin-missing-exports": "^0.23.0",
"typedoc-plugin-rename-defaults": "^0.6.4",
"typescript": "^4.8.3"
Copy link
Member

@auscompgeek auscompgeek Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume there was a good reason for pinning the TypeScript version in the first place here?

Suggested change
"typescript": "^4.8.3"
"typescript": "~4.8.3"

}
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,8 +762,8 @@
"prettier": "2.7.1",
"semver": "^7.3.7",
"sinon": "^11.1.1",
"ts-unused-exports": "^8.0.0",
"typescript": "4.6.3"
"ts-unused-exports": "8.0.0",
"typescript": "^4.8.3"
Comment on lines +765 to +766
Copy link
Member

@auscompgeek auscompgeek Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Suggested change
"ts-unused-exports": "8.0.0",
"typescript": "^4.8.3"
"ts-unused-exports": "~8.0.0",
"typescript": "~4.8.3"

},
"dependencies": {
"immer": "^9.0.15",
Expand Down