Conversation
78fa594 to
d6fe259
Compare
252ca38 to
bbc1ca4
Compare
a3e4576 to
90619bc
Compare
7350720 to
adf7c5e
Compare
adf7c5e to
7ba66c5
Compare
|
Closing until someone has bandwidth to finish this PR |
|
After discussion in meet-up: Just kidding; let's get this thing in for the languages that exist here. more useful to at least have it functional in some places |
7f8ad4c to
20f4c8b
Compare
|
We should also test:
|
| marks: {} | ||
| finalState: | ||
| documentContents: |- | ||
|
|
There was a problem hiding this comment.
It feels a bit weird for branch to work on the try block itself 🤷
There was a problem hiding this comment.
Yeah I'm not entirely sure what the use case for that is tbh 😅, but seemed consistent, and maybe someone would want to use it with the copy action?
Unfortunately that is blocked on #1201 😕 |
Ah, I was afraid as such. |
auscompgeek
left a comment
There was a problem hiding this comment.
I think the implicit "this" change got cherry-picked into this branch for some reason, but otherwise LGTM.
I presume it should be trivial to reuse the if/else matchers for Java and C++ like we did for Rust, and I hope the same for try/catch, so might be worth doing it here anyway.
| "selector": "selector", | ||
| "state": "statement", | ||
| "string": "string", | ||
| "branch": "branch", |
There was a problem hiding this comment.
nit: any reason this is listed in this order in particular?
There was a problem hiding this comment.
Not really. I should prob file a follow-up to alphabetise; didn't want to mess with the diff
Strange. That's already merged into main anyway, but looks like the parentage is strange here; I'll have a look
Unfortunately not 😕. Java, C#, and C++ don't have a special node for else clauses, so the logic gets more complicated. Should be doable, but not just a quick afterthought like one would hope. I'd be inclined to leave for follow-up work |
397d6ab to
643090e
Compare
"branch"scope type #1173Checklist
Co-authored-by: Michael Doronin warrior2031@mail.ru