Conversation
Member
Author
|
@pokey Updated with new generator format |
pokey
reviewed
Oct 30, 2022
Member
pokey
left a comment
There was a problem hiding this comment.
Looks good! Worth migrating all block tests to scopes/paragraph directory and then seeing what's missing. Upon a quick glance I didn't see any "next", "previous", or "n blocks" tests. Worth having some with edge cases too. I think probably want cross product of:
- empty cursor at start of block
- empty cursor in middle of block
- empty cursor at end of block
Cross with
- "block"
- "next block"
- "previous block"
- "two blocks"
- "two blocks backward"
It looks like we already have a few "every" tests, so probably ok on that front? Worth quick review tho
A bit annoying we still have to do all these cross products. If we tested the scope handler directly we could do many fewer tests 🤔
Member
Author
|
Tests added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1055
Checklist