Conversation
Member
Author
|
@pokey Added this draft so we can discuss it on the meet up |
pokey
force-pushed
the
one_of_compound_scope_type
branch
from
5baeecf to
fb5d268
Compare
pokey
changed the base branch from
main
to
pokey/simplify-default-iteration-scopes-file-scopehandler
pokey
reviewed
Oct 23, 2022
src/processTargets/modifiers/scopeHandlers/OneOfScopeHandler.ts
Outdated
Show resolved
Hide resolved
pokey
reviewed
Oct 23, 2022
Base automatically changed from
pokey/simplify-default-iteration-scopes-file-scopehandler
to
main
October 24, 2022 08:22
pokey
force-pushed
the
one_of_compound_scope_type
branch
from
68543ea to
f5379b1
Compare
pokey
previously approved these changes
Oct 24, 2022
pokey
approved these changes
Oct 24, 2022
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
I guess let's merge this in for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1045
Checklist