Hotfix redis cache

[lodewiges]

Checklist

• Merged database migrations into 1 database migration.
• Tested database migrations from origin/staging (git checkout staging ; git pull ; bundle exec rails db:reset ; git checkout BRANCH ; bundle exec rails db:migrate).

Summary

Shortly summarize the changes in this pull request. Does it concern changes in the UI, add some screenshots. Are there related issues solved? Please, mention them (with 'fixes #xyz', see https://github.com/blog/1506-closing-issues-via-pull-requests), so they can be resolved automatically when merging this pull request.

Other information

If there is some other relevant and important information for this pull request, mention it here. For example, related pull requests or newly introduced conventions, packages or other dependencies.

Summary by CodeRabbit

• Bug Fixes

  • Improved payments form submission reliability by disabling Turbo for that form, resulting in more consistent behavior.

• Chores

  • Added Redis as a runtime dependency to support application infrastructure.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds gem "redis", "~> 5.0" to project dependencies and disables Turbo on the payments add form by adding data: { turbo: false } to the simple_form_for call.

Changes

Cohort / File(s)	Summary
Dependency Gemfile	Adds gem 'redis', '~> 5.0' to project dependencies.
Form configuration app/views/payments/add.html.erb	Adds data: { turbo: false } to the simple_form_for call to disable Turbo-driven submission.

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant RailsApp
  participant Redis

  rect rgb(230,248,255)
    note right of Browser: Non‑Turbo flow (current change)
    Browser->>RailsApp: Full POST /payments (form submit)
    RailsApp->>RailsApp: Controller processes payment
    RailsApp->>Redis: Optional cache/read (if used)
    RailsApp-->>Browser: Full HTML response or redirect
  end

  rect rgb(245,245,245)
    note right of Browser: Turbo-enabled flow (previous behavior)
    Browser->>RailsApp: Turbo/XHR frame request
    RailsApp->>RailsApp: Controller processes payment
    RailsApp-->>Browser: Turbo stream / partial HTML
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Pay attention to: correct gem name/version and running bundle install; confirm disabling Turbo doesn't break client-side expectations or JS hooks in app/views/payments/add.html.erb.

Possibly related PRs

• Remove redis-rails #1133: Related to Redis dependency changes (this PR adds redis, that PR modifies/removes other redis-related gems).

Poem

🐰 I found a gem and made a tiny change,
Forms slow their bustle, no more Turbo range.
Queues might hum where caches lay,
A quiet hop, a smoother day,
Nibble a carrot — code in range. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description contains only the template placeholders with no actual content filled in. All sections are empty templates without concrete information about changes, testing, or related issues.	Complete all required sections: provide a summary of changes (mentioning the redis gem addition and form turbo flag), specify any related issues, and document testing steps performed.
Title check	❓ Inconclusive	The title 'Hotfix redis cache' is vague and generic. While it mentions redis, it doesn't specify what the actual fix entails—whether it's adding redis support, fixing a bug, or resolving a performance issue.	Provide a more descriptive title that clearly indicates the specific problem being addressed, such as 'Add redis dependency for caching' or 'Fix redis cache initialization'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch hotfix/fix-redis-cache

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

Gemfile (1)

32-32: Use the redis gem with Rails 7's built-in cache store instead of redis-rails.

While redis-rails is actively maintained, Rails 7 includes native Redis cache store support. Using the redis gem directly with config.cache_store = :redis_cache_store aligns with Rails 7's recommended caching approach and simplifies dependency management.

Update your Gemfile:

-gem "redis-rails", "~> 5.0"
+gem "redis", "~> 5.0"

Then configure in config/environments/production.rb:

config.cache_store = :redis_cache_store, {
  url: ENV.fetch("REDIS_URL", "redis://localhost:6379/1"),
  expires_in: 90.minutes
}

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7cb8a5e and 2fb979e.

⛔ Files ignored due to path filters (1)

• Gemfile.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

• Gemfile (1 hunks)
• app/views/payments/add.html.erb (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.27%. Comparing base (7cb8a5e) to head (43255d8).
⚠️ Report is 1 commits behind head on staging.

Additional details and impacted files

@@           Coverage Diff            @@
##           staging    #1134   +/-   ##
========================================
  Coverage    75.27%   75.27%           
========================================
  Files           50       50           
  Lines         1076     1076           
========================================
  Hits           810      810           
  Misses         266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Gemfile (1)

1-45: PR description is incomplete; related file from AI summary is missing.

The PR description contains unchecked items ("Merge database migrations," "Test database migrations") and placeholder sections. The AI-generated summary mentions a second change—disabling Turbo on the payments add form (data: { turbo: false })—but app/views/payments/add.html.erb is not provided for review.

Ensure:

1. All changed files are included in the review.
2. The PR description is completed with a clear summary of the problem, the fix, and any related issues (e.g., "fixes #xyz").
3. Database migration steps are validated per the unchecked checklist.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4022d94 and 43255d8.

📒 Files selected for processing (1)

• Gemfile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify redis is needed as an explicit dependency.

Redis is added with ~> 5.0 at line 32, resolving to version 5.4.1. Since Sidekiq (line 37, ~> 8.0.9) already includes redis as a transitive dependency, adding it explicitly may be redundant unless:

1. The project requires redis independently (beyond Sidekiq).
2. This pins a specific version to address a compatibility issue.
3. Sidekiq's version constraint no longer includes redis.

Clarify why redis must be an explicit dependency and whether the version constraint aligns with your stability/security requirements.

Run the following script to check Sidekiq's dependency on redis and the current Gemfile.lock state:

---

🏁 Script executed:

#!/bin/bash
# Check whether Sidekiq 8.0.9 depends on redis and what version it expects
gem dependency sidekiq --version "8.0.9" 2>/dev/null | grep redis || echo "Sidekiq 8.0.9 dependency tree not available locally"

# Check if Gemfile.lock already resolves redis transitively from Sidekiq
echo "--- Checking Gemfile.lock for redis ---"
grep -A 5 "redis" Gemfile.lock | head -20

Length of output: 671

---

Fix critical Redis version mismatch with Sidekiq 8.0.9.

The redis gem is correctly added as an explicit dependency (needed by redis-store, redis-rails, etc.). However, Redis 7.0 is the minimum required version for Sidekiq 8.x. The constraint ~> 5.0 resolves to 5.4.1, which will cause runtime failures when Sidekiq tries to connect.

Change line 32 to: gem 'redis', '~> 7.0'

🤖 Prompt for AI Agents

In Gemfile around line 32, the redis gem constraint '~> 5.0' is incompatible
with Sidekiq 8.x (requires Redis >= 7.0); update the line to use the newer
constraint by changing the version specifier to '~> 7.0' and then run bundle
install (or bundle update redis) to update the lockfile so Sidekiq will use a
compatible Redis client version.