parser-json-cov: process nested events recursively#222
Closed
kdudka wants to merge 6 commits intocsutils:mainfrom
Closed
parser-json-cov: process nested events recursively#222kdudka wants to merge 6 commits intocsutils:mainfrom
kdudka wants to merge 6 commits intocsutils:mainfrom
Conversation
Member
Author
|
/packit rebuild-failed |
... to make the code easier to extend. No change in behavior intended. Related: csutils#222
No change in behavior intended with this commit. Related: csutils#222
kdudka
force-pushed
the
cov-nested-evt
branch
from
799844f to
12dd645
Compare
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 26, 2025
... to make the code easier to maintain. No change in behavior intended. Related: csutils#222
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 26, 2025
... to make the code ready for processing nested events. No change in behavior with this commit yet. Related: csutils#222
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Feb 26, 2025
lzaoral
approved these changes
Feb 26, 2025
Member
lzaoral
left a comment
lzaoral
left a comment
There was a problem hiding this comment.
LGTM! Minor suggestion inline.
... to make the code easier to maintain. No change in behavior intended. Related: csutils#222
... to make the code ready for processing nested events. No change in behavior with this commit yet. Related: csutils#222
kdudka
force-pushed
the
cov-nested-evt
branch
from
12dd645 to
2ee9132
Compare
Member
Author
|
@lzaoral Thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.