Closed
Conversation
Member
|
I'm afraid, that this hack will have to stay since the GitHub macOS images are broken by design. |
kdudka
force-pushed
the
fix-macos-ci
branch
4 times, most recently
from
9981f3e to
40866b4
Compare
It does not seem to be needed any more. Related: csutils#214
... so that it works with Boost Python and does not fail with:
```
-- Found Boost: /opt/homebrew/lib/cmake/Boost-1.86.0/BoostConfig.cmake (found version "1.86.0") found components: filesystem program_options regex system json nowide
-- Found Python3: /opt/homebrew/Frameworks/Python.framework/Versions/3.13/bin/python3 (found version "3.13.0") found components: Development Interpreter Development.Module Development.Embed
CMake Warning (dev) at src/CMakeLists.txt:129 (find_package):
Policy CMP0167 is not set: The FindBoost module is removed. Run "cmake
--help-policy CMP0167" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.
Call Stack (most recent call first):
src/CMakeLists.txt:165 (build_pycsdiff)
This warning is for project developers. Use -Wno-dev to suppress it.
CMake Error at /opt/homebrew/lib/cmake/Boost-1.86.0/BoostConfig.cmake:141 (find_package):
Found package configuration file:
/opt/homebrew/lib/cmake/boost_python-1.86.0/boost_python-config.cmake
but it set boost_python_FOUND to FALSE so package "boost_python" is
considered to be NOT FOUND. Reason given by package:
No suitable build variant has been found.
The following variants have been tried and rejected:
* libboost_python312-mt.dylib (3.12, Boost_PYTHON_VERSION=3.13)
* libboost_python312-mt.a (3.12, Boost_PYTHON_VERSION=3.13)
* libboost_python312.dylib (3.12, Boost_PYTHON_VERSION=3.13)
* libboost_python312.a (3.12, Boost_PYTHON_VERSION=3.13)
Call Stack (most recent call first):
/opt/homebrew/lib/cmake/Boost-1.86.0/BoostConfig.cmake:262 (boost_find_component)
/opt/homebrew/Cellar/cmake/3.30.5/share/cmake/Modules/FindBoost.cmake:610 (find_package)
src/CMakeLists.txt:129 (find_package)
src/CMakeLists.txt:165 (build_pycsdiff)
-- Configuring incomplete, errors occurred!
make[1]: *** [all] Error 1
make: *** [distcheck] Error 2
```
Closes: csutils#214
kdudka
changed the title
Member
|
Oh, I see now. This is actually a problem with Homebrew... Default python is 3.13 but |
lzaoral
approved these changes
Oct 23, 2024
Member
Author
|
@lzaoral Thanks for review! |
kdudka
pushed a commit
to kdudka/csdiff
that referenced
this pull request
Feb 5, 2025
... so that we do not need to bump the version manually in the YAML file Fixes: commit 56ac540 Related: csutils#214
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.