html-writer: use the term "finding"#197
Merged
siteshwar merged 2 commits intocsutils:mainfrom Jul 25, 2024
Merged
Conversation
siteshwar
force-pushed
the
github-193
branch
2 times, most recently
from
0275d0a to
e2c24bb
Compare
... instead of "defect" in the reports. Resolves: csutils#193 Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
kdudka
reviewed
Jul 25, 2024
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Looks good. I would also rename the newDefect CSS class to newFinding for consistency.
... to `newFinding` for consistency. Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
Member
Author
|
There is also the use of EDIT: My interpretation of |
Member
|
Yep, I would keep |
kdudka
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... instead of "defect" in the reports.
Resolves: #193