msg-filter: abstract out numbers from error[too-many] findings#188
Merged
kdudka merged 1 commit intocsutils:mainfrom Jun 14, 2024
Merged
msg-filter: abstract out numbers from error[too-many] findings#188kdudka merged 1 commit intocsutils:mainfrom
kdudka merged 1 commit intocsutils:mainfrom
Conversation
jperezdealgaba
commented
Jun 12, 2024
jperezdealgaba
force-pushed
the
filter-many-events
branch
3 times, most recently
from
55f3ae2 to
e07e367
Compare
kdudka
requested changes
Jun 12, 2024
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
@jperezdealgaba Please update the regression test such that it covers the code change. As it is now, if I revert the code change, the test is still passing.
jperezdealgaba
force-pushed
the
filter-many-events
branch
from
e07e367 to
33b0650
Compare
Contributor
Author
|
@kdudka I can not reply to your comment directly. Test cases added to reflect the new changes. |
kdudka
force-pushed
the
filter-many-events
branch
2 times, most recently
from
4c6aa94 to
d04bfcb
Compare
kdudka
changed the title
kdudka
approved these changes
Jun 14, 2024
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Thanks for the update! I have anchored the regex to match only full strings and updated the commit message to describe what the change actually does.
Abstract out the number of occurrences and configured rate limit in `error[too-many]` findings. Resolves: https://issues.redhat.com/browse/OSH-496 Closes: csutils#188
kdudka
force-pushed
the
filter-many-events
branch
from
d04bfcb to
3c764eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added filter and test for error[too-many] findings in csdiff in order to apply the filter deterministically even if the location and the number of occurrences vary
Resolves: https://issues.redhat.com/browse/OSH-496