Add a new github workflow 'tag'#164
Merged
turkenh merged 2 commits intocrossplane-contrib:mainfrom Jan 28, 2025
Merged
Conversation
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
turkenh
reviewed
Jan 27, 2025
| @@ -0,0 +1,26 @@ | |||
| name: Tag | |||
Contributor
There was a problem hiding this comment.
Is this required?
AFAIU, @negz didn't include this workflow in the functions (e.g. https://github.com/crossplane/function-template-go) to keep things simple, e.g. in favor tagging directly from Github UI.
Contributor
There was a problem hiding this comment.
I can see this as helpful in terms of being consistent with other extension repositories, though.
Member
There was a problem hiding this comment.
Yes, I'd rather not have the tag workflow for functions. I haven't found it to be needed. As @turkenh mentioned, it's just as easy to create a tag from the GitHub UI when cutting a release.
turkenh
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new GitHub workflow
tag.yml, andOWNERS.md,CODEOWNERSfiles.