Merged
Conversation
f0a94e3 to
fa14ec9
Compare
Collaborator
Author
|
#116 shoudl get merged first |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR speeds up the E2E functional classification tests by reusing a single long-lived streaming gRPC connection across cases, and adds an env-var-based selector for which testcase directory to run.
Changes:
- Added
StreamingSender+streaming_sendersession fixture to reuse a persistentclassify_imagesstream for E2E runs. - Switched the E2E test to use
streaming_sender.send(...)and made testcase selection configurable viaATHENA_E2E_TESTCASE_DIR. - Documented the new E2E configuration in the README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| tests/functional/e2e/testcases/parser.py | Adds env-var driven testcase loading (ATHENA_E2E_TESTCASE_DIR). |
| tests/functional/e2e/test_classify_single.py | Uses the new session-scoped streaming sender to classify each E2E case faster. |
| tests/functional/conftest.py | Introduces the StreamingSender helper and a session-scoped streaming_sender fixture; modifies athena_options scope and compression quality. |
| README.md | Documents E2E behavior and the ATHENA_E2E_TESTCASE_DIR environment variable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ShaunWatsonCrisp
approved these changes
Mar 9, 2026
snus-kin
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a fixture that holds open a streaming connection to speed up the e2e test cases by 4x! (on the benign_model set)
Current Speed of benign_model: ~160s
New Speed of benign_model: ~38s
We could actually go faster (all cases running in ~6s) by using subtests, but then we lose the ability to run single cases.