Open
Conversation
new Buffer is deprecated
|
This would be very nice to have :) @creationix? |
Owner
|
This is great, but there is no need to check every time the function is called. Instead of having the indirection that checks at runtime every time the function is called, simply set the function. // Use Buffer.from directly if it exists. Otherwise, create a version of the constructor that works like a function.
const bufferFrom = Buffer.from ? Buffer.from : (...args) => new Buffer(...args); |
|
ok, but can this be addressed? its been 2 years now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new Buffer is deprecated, so Buffer.from should be used if it's available