Skip to content

Conversation

@Jimbly
Copy link
Collaborator

@Jimbly Jimbly commented Feb 13, 2019

Update tests to work on Node v10.x.
Resolves #58
Thanks @paulrutter, code mostly from your PR. Other changes I just diffed with what's in nodejs/master and saw what they changed, and it seemed to resolve things.
All tests should pass on v6, v8, v10, and v11.

Update tests to work on Node v10.x.
Resolves #58
@Jimbly Jimbly merged commit 3314397 into master Feb 13, 2019
@Jimbly Jimbly deleted the node10x branch February 13, 2019 17:06
@paulrutter
Copy link
Contributor

Thanks @Jimbly!
Shouldn't we also update the package.json version and publish it as new version to NPM?

@Jimbly
Copy link
Collaborator Author

Jimbly commented Feb 14, 2019

I almost did... but then realized nothing has changed. The only changes we've made have been to Node.js and the test behavior, http-parser.js is unchanged.

@paulrutter
Copy link
Contributor

paulrutter commented Feb 14, 2019

Hehe, you're right indeed.
In the end it was quite some work, but we ended up changing nothing (in code) at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants